Doll species - #5013
Open
Citrea-Lingua wants to merge 41 commits into
Open
Conversation
github-actions
Bot
added
S: Needs Review
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
Bot
added
the
S: Merge Conflict
Member
|
Closed as stale |
Contributor
|
Drafts should probably have more leeway for being marked stale, thats the whole point of marking as a draft. |
Contributor
Author
|
Not only is this a draft, it is a draft specifically for people to test. |
Member
the whole point of marking as a draft is that it's PR in active development, so people can check it before it will be ready for review. This PR isn't in active development as I see |
Contributor
Author
|
I am reasonably happy with it now, and will reopen this for final checks, comments and ideas before I mark it as ready to go. |
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 SummarySummaryAdds the Doll species, a sapient meat-anomaly species concealed beneath ceramic shells. Gameplay and user impact
Notable implementation changes
Risk areas
Guideline gaps
WalkthroughAdds the Doll species with custom organs, body parts, shell mechanics, surgery, metabolism, survival supplies, damage handling, localization, guidebook content, and sprite metadata. It also updates fake-death, magic item spawning, and vent-crawl behavior. ChangesDoll species and shell mechanics
Shared behavior and support
Estimated code review effort: 5 (Critical) | ~120 minutes Merge Risk: 🟡 Moderate · up to The Doll species feature still contains several gameplay and content correctness issues, including bypassable movement restrictions, incorrect shell-state behavior, missing body functionality, and inaccurate survival equipment or player-facing text. The PR is not merge-ready until these bounded issues are fixed or explicitly accepted by the appropriate owners. Sequence Diagram(s)sequenceDiagram
participant Doll
participant ActionSystem
participant SurgeryActionSystem
participant OrganSystem
participant DamageableSystem
Doll->>ActionSystem: use shell-piece or surgery action
ActionSystem->>SurgeryActionSystem: dispatch configured action event
SurgeryActionSystem->>OrganSystem: select and execute surgery step
OrganSystem->>DamageableSystem: apply shell damage modifiers
OrganSystem-->>Doll: update shell components, markings, and actions
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 30.77% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 26 functions across 13 files. (1 skipped: 1 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…structure left in place.
github-actions
Bot
removed
the
S: Merge Conflict
Contributor
Content + Integration Test ResultsFailed Tests
Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Contributor
Author
|
Woo, found the issue, will fix yml lint tomorrow |
Contributor
Author
|
Woo, all checks green! Now it should finally actually be ready for review xD |
Contributor
Author
|
Doooo I need to learn about partials straight away and re-rig all of this for the new system? 😅 |
Contributor
This is all new content in _Starlight files so should be fine as is. |
Collaborator
|
no you get grandfathered in |
Contributor
Author
|
Back in my day...! :P |
Contributor
Author
|
Do I want to expand this with a crafting recipe for making an empty doll body from meat anom cores... |
walksanatora
approved these changes
Sep 3, 2026
starlightgithub
Bot
added
S: Approved
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 3, 2026
walksanatora
previously approved these changes
Sep 3, 2026
walksanatora
enabled auto-merge
September 3, 2026 05:36
auto-merge was automatically disabled
September 3, 2026 06:51
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Adds the doll species from https://discord.com/channels/1272545509562777621/1464734978859466833
Why we need to add this
Spooky, non-humanoid species, and multiple players seemed to be interested in it ^^
Here's their guidebook entry, for a species description~
The common perception of Dolls is one of cold, unmoving faces and eerily fluid motion. This is, of course, a deliberately chosen look - as they fear being outcast or even hunted, were people to look underneath their shell.
In reality, Dolls are a recently discovered, sapient strain of meat anomaly creatures, hiding their rather disturbing forms underneath a hard, ceramic-like shell. It is more than just a suit - a Doll's shell is a core part of their very self. While they are able to leave it behind, they are unwilling to do so, save for extreme emergencies, and outside attempts to remove it are oft met with violent resistance.
Diet
Dolls are anomalous creatures of flesh. As such, their diet consists of meat and blood, though they do not care whether it has been cooked beforehand. Consuming blood will also slowly heal a Doll, including their shell - though the mechanism for this is unknown.
Racial Features
The Shell
You have an outer shell hiding away your meaty tendrils. You should keep it on at all times! At need, you can break off small, spare pieces of your shell - which is a pretty painful process - to use as a makeshift knife, or to give to another doll, should the worst happen and their shell was stolen.
With Shell
Without Shell
Notably:
The damage resistance changes with the amount of installed shell pieces. As a side effect, organs and other parts applying additive damage modifiers are now possible.
New MarkingOrganComponent allows applying and removing markings when an organ is installed or removed.
Media (Video/Screenshots)
TODO
Checks
Changelog
🆑 Citrea, Ashley Black, Maitake & Seven Shades (Plus various people suggesting names)